Add missing defer summarize(req) in UninstallRemediation#1491
Conversation
|
Thanks for the patch. Double checked things, and However, before this can be merged, please add a test in Also: if this work was assisted by an LLM, please add the appropriate trailer to the commit per https://github.com/fluxcd/helm-controller?tab=contributing-ov-file#ai-coding-assistants-guidance. |
SebTardif
force-pushed
the
fix/uninstall-remediation-summarize
branch
from
87abc54 to
98f45a8
Compare
UninstallRemediation is the only action reconciler that does not call defer summarize(req). All other reconcilers (Install, Upgrade, Test, Uninstall, Unlock, RollbackRemediation) include this deferred call to propagate sub-conditions into the top-level Ready condition. Without this call, the Ready condition is never updated after an uninstall remediation, leaving a stale status until the next reconciliation pass. Add ReadyCondition assertions to all test cases (success and failure) to prevent regressions, matching the pattern in rollback_remediation_test.go. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca> Assisted-by: Grok/grok-4
SebTardif
force-pushed
the
fix/uninstall-remediation-summarize
branch
from
98f45a8 to
5835cd9
Compare
|
Updated with ReadyCondition assertions on all test paths (success and failure), matching the pattern in rollback_remediation_test.go. The Assisted-by trailer was already present. |
2 participants
Description
UninstallRemediation.Reconcileis the only action reconciler that does not calldefer summarize(req). All six other reconcilers (Install,Upgrade,Test,Uninstall,Unlock,RollbackRemediation) include this call.Without it, the
Readycondition is never updated after an uninstall remediation, andObservedPostRenderersDigest/ObservedCommonMetadataDigestare not refreshed.Closes #1488
Changes
One-line addition:
defer summarize(req)after the variable block, matching all other reconcilers.Verification
go build ./...passesgo vet ./...passes